slachiewicz opened a new pull request, #148: URL: https://github.com/apache/maven-common-artifact-filters/pull/148
Deduplicate `AbstractPatternArtifactFilterTest` by extracting `newArtifact(groupId, artifactId)` and `assertInclusion(filter, artifact)` helpers shared by all 20 `@Test` methods in both concrete subclasses. No new dependencies; no test case, assertion or test method removed (net -130 lines). The one test with a bespoke mock (`partialWildcardShouldNotMatchEmptyComponent`, stubbing `getVersion()`/`hasClassifier(false)`) keeps its setup and inverted assertion convention. Tracking: apache/maven#14072 Verified: `JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home mvn -B -o test` — BUILD SUCCESS, 236 tests, 0 failures, 0 errors, 0 skipped. Per-class counts unchanged from baseline: PatternIncludes 20, PatternExcludes 20, StrictPatternIncludes 54, StrictPatternExcludes 54. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
