slachiewicz opened a new pull request, #486:
URL: https://github.com/apache/maven-wrapper/pull/486

   The four repo-URL fallback tests in `WrapperMojoTest` are copy-pasted 
variants of one behavior: an unusable `repoUrl` resolves to `DEFAULT_REPO_URL`. 
Parameterizing them keeps all four cases exercised in one place.
   
   Changes:
   - Replaced the four repo-URL tests with one `@ParameterizedTest` using 
`@NullAndEmptySource` + `@ValueSource(strings = {"/", DEFAULT_REPO_URL + "/"})` 
(four executed cases: null, empty, "/", default URL with trailing slash).
   - Added BOM-managed `junit-jupiter-params` test dependency with no explicit 
version.
   
   Stacked on #463; branch contains the blocker's commits. Rebase after the 
blocker merges.
   Blocker credit: PR #463 by @arturobernalg ("Retain distributionSha256Sum 
when reinstalling the same Maven distribution"). Base: master.
   
   Tracking: apache/maven#14072
   Verified: `JAVA_HOME=.../zulu-21.jdk/Contents/Home mvn -B -o test` -> BUILD 
SUCCESS; WrapperMojoTest 8 tests (4 parameterized cases + 4 unchanged), other 7 
test classes 30 tests, 38 total, 0 failures/errors (per-class counts unchanged 
from baseline). Java 8 floor preserved: JUnit 5.14.4 comes from the BOM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to