slachiewicz opened a new issue, #200:
URL: https://github.com/apache/maven-shared-jar/issues/200

   `StaticMainOutputExposer` is registered as a Sisu component (`@Singleton`, 
`@Named("staticMainOutput")`) but contributes nothing to jar identification.
   
   `expose()` calls `findStaticMainVersions()`, whose body is a TODO followed 
by `return Collections.emptyList()`. The class Javadoc also says "TODO not 
currently implemented". The component is therefore always a no-op and adds an 
entry to the component set without producing any version.
   
   Two options need a maintainer decision:
   
   1. Remove the class and its component registration. This is the simplest 
cleanup but changes the published component set and a public type, so it 
belongs in a major release.
   2. Implement the described behavior (execute static `main` methods of 
classes whose name contains `Version` and record the reported version). This is 
a new feature with security and reliability implications, so it needs its own 
design.
   
   Until one is chosen, the class should stay as it is. Filing this to record 
the decision rather than leaving an unexplained stub in the code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to