gnodet commented on PR #14066: URL: https://github.com/apache/maven/pull/14066#issuecomment-7013471597
Thank you for the feedback. I want to clarify what this PR now contains, as it has been significantly narrowed since your review. **The noun-style accessor methods have been removed from this PR.** The PR no longer introduces any `name()` / `value()` / `groupId()` style methods on the core API interfaces (`Artifact`, `Node`, `Project`, etc.). That work has been moved to dedicated PRs (#14067 and #14068) which target `master` and will be discussed on their own merits. What remains in this PR is scoped specifically to: 1. A new `maven-api-log` module introducing `Logger`/`LogEventBuilder`/`LogLevel` — a proper plugin logging API for Maven 4.0 to replace the aging `org.apache.maven.api.plugin.Log` 2. `plugin.Log` marked `@Deprecated` in favour of the new `Logger` (binary-compatible — the interface is preserved) 3. `Session.getDegreeOfConcurrency()` marked `@Deprecated` with a `degreeOfConcurrency()` bridge (one method, same concern about the existing `Log` API) 4. `ModelProcessor.read(XmlReaderRequest)` deprecated in favour of a new `read(Source, Map)` overload None of this introduces noun-style naming. The concern you raised about naming churn does not apply to the current state of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
