arturobernalg opened a new pull request, #13953: URL: https://github.com/apache/maven/pull/13953
DefaultModelBuilder.readModel() reaches this branch only when the strict parse fails but a non-strict retry succeeds. The modello- generated reader's strict flag only gates schema-shape checks (unrecognized/misplaced elements, unknown attributes, namespace); raw XML well-formedness is enforced by the underlying parser regardless of that flag, so a document that is not well-formed XML at all fails both attempts and is reported separately as "Non-parseable POM". Whenever this branch runs, the document is therefore well-formed XML that merely violates the POM schema - invalid, not malformed. Change the message to say so, matching what the reporter (a committer on this project) found confusing: "the POM was well-formed as all tags balanced... invalid, not malformed, because the tags weren't where they should be." Fixes #8438 --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
