charangowdamd-cmd commented on PR #13941:
URL: https://github.com/apache/maven/pull/13941#issuecomment-6769663148
Addressed review feedback:
1. **Log `LookupException` at `WARN`**: Updated `AbstractSession.java` to
log `LookupException` via SLF4J at `WARN` level rather than silently swallowing
it, ensuring DI container provisioning failures are visible.
2. **Removed implementation class names from API Javadoc**: In
`Listener.java`, removed references to internal class names (`EventSpyImpl`,
`MavenRepositoryListener`) in favor of generic terms ("event dispatchers").
3. **Added test coverage**: Added
`handlesLookupExceptionDuringSpiDiscoveryGracefully` in `EventSpyImplTest.java`
verifying that when `lookupList()` throws `LookupException`, it is logged and
the session initializes cleanly with an empty listeners list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]