slachiewicz opened a new issue, #3580:
URL: https://github.com/apache/maven-surefire/issues/3580

   `ProviderParameters.getDirectoryScanner()`, the `DirectoryScanner` interface 
and its `DefaultDirectoryScanner` implementation in `surefire-api` are 
deprecated in favour of `getScanResult()`, and nothing in Surefire uses them 
any more: the plugin scans test classes with its own `FileScanner` and hands 
the result to every bundled provider through `getScanResult()`. They survive 
only for third-party providers that still call the old method.
   
   A search of public code finds three such providers outside copies of 
Surefire's own sources:
   
   - 
[LudoMeurillon/CodingMojo](https://github.com/LudoMeurillon/CodingMojo/blob/master/maven-surefire-replay/src/main/java/org/apache/maven/surefire/providerapi/CodingMojoProviderParameter.java),
 last pushed in 2013
   - 
[wannessels/cloud-build-plugin](https://github.com/wannessels/cloud-build-plugin/blob/master/src/main/java/be/waines/maven/junit/CloudJunitProvider.java),
 last pushed in 2015
   - 
[deepin-community/spock](https://github.com/deepin-community/spock/blob/master/spock-maven/src/main/java/org/apache/maven/surefire/junitcore/SpockProvider.java),
 a distribution's packaging copy of an old `spock-maven` provider
   
   None is maintained against current Surefire, and a provider that is can move 
to `getScanResult()` with a small change on its side. This proposes removing 
`getDirectoryScanner()`, `DirectoryScanner` and `DefaultDirectoryScanner`, 
together with what only they use: `BaseProviderFactory.getDirectoryScanner()` 
and the include/exclude handling in `DefaultDirectoryScanner`. 
`DirectoryScannerParameters` stays, since the plugin still passes includes and 
excludes to the forked JVM through it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to