slachiewicz commented on code in PR #2292: URL: https://github.com/apache/maven-resolver/pull/2292#discussion_r4507894494
########## maven-resolver-transport-apache/src/test/java/org/eclipse/aether/transport/apache/AwsSigV4ApacheTransporterIT.java: ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.eclipse.aether.transport.apache; + +import java.io.IOException; +import java.net.HttpURLConnection; +import java.net.URI; +import java.nio.charset.StandardCharsets; + +import org.eclipse.aether.ConfigurationProperties; +import org.eclipse.aether.DefaultRepositorySystemSession; +import org.eclipse.aether.repository.RemoteRepository; +import org.eclipse.aether.spi.connector.transport.GetTask; +import org.eclipse.aether.spi.connector.transport.PeekTask; +import org.eclipse.aether.spi.connector.transport.PutTask; +import org.eclipse.aether.spi.connector.transport.Transporter; +import org.eclipse.aether.spi.connector.transport.TransporterFactory; +import org.eclipse.aether.spi.io.PathProcessorSupport; +import org.eclipse.aether.util.connector.transport.http.AwsSigV4RequestSigner; +import org.eclipse.aether.util.repository.AuthenticationBuilder; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.testcontainers.containers.MinIOContainer; +import org.testcontainers.junit.jupiter.Container; +import org.testcontainers.junit.jupiter.Testcontainers; +import org.testcontainers.utility.DockerImageName; + +import static org.junit.jupiter.api.Assertions.*; + +/** + * The transporter against an S3-compatible store with {@code aws-sigv4} request signing: a plain HTTP repository + * URL whose path names the bucket and prefix, and the repository username and password as access and secret key. + */ +@Testcontainers(disabledWithoutDocker = true) +class AwsSigV4ApacheTransporterIT { + private static final String BUCKET = "sigv4"; + + private static final String REGION = "us-east-1"; + + @Container + static final MinIOContainer CONTAINER = + new MinIOContainer(DockerImageName.parse("pgsty/silo:RELEASE.2026-09-03T13-18-01Z-distroless") + .asCompatibleSubstituteFor("minio/minio")); Review Comment: Kept on purpose: `pgsty/silo` is what `MinioTransporterIT` on master has used since #2140, so all the S3-compatible ITs run against one image. Pinning it by digest would be a separate change covering all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
