DavJaveiro commented on issue #663:
URL:
https://github.com/apache/maven-pmd-plugin/issues/663#issuecomment-6723937996
cc @elharo @slawekjaranowski
Still reproducible on master (`aa140a9`) — though not via `mvn
javadoc:javadoc`. The warnings are emitted by
`maven-plugin-plugin:3.16.0:descriptor` during `mvn package`, while the
java-annotations mojo extractor resolves Javadoc links for parameter
descriptions. The three warnings repeat once per report mojo scanned (6x total).
- `Unresolvable link ... #getOutputName()` comes from the `outputDirectory`
field Javadoc in `AbstractMavenReport` (maven-reporting-impl 4.0.0, extracted
to `target/maven-plugin-plugin-sources`). The method isn't declared in that
class — it's inherited from the `MavenReport` interface, whose sources aren't
part of the extraction model.
- `Could not get javadoc URL for SiteTool#DEFAULT_LOCALE` /
`SiteTool#getSiteLocales(String)` comes from the `locale` field Javadoc in the
same class — no associated javadoc site for doxia.
Note this is unrelated to the `{@inheritDoc}` on the deprecated
`getOutputName()` overrides in `PmdReport`/`CpdReport` — those produce no
warnings.
This was already fixed upstream in maven-reporting-impl@e890917a ("Replace
Javadoc links the plugin descriptor cannot resolve"), which rewrote those docs
to use `{@code getOutputPath()}` / `{@code SiteTool...}`. 4.0.0 is still the
latest release, so the warnings will go away once a new maven-reporting-impl is
adopted here.
As far as I can tell there is no clean fix possible in this repo today:
`externalJavadocBaseUrls` could resolve the `SiteTool` refs but requires
connectivity during the build and doesn't fix the `#getOutputName()` link;
re-declaring the inherited `outputDirectory`/`locale` fields just to shadow
their docs would be wrong.
So I'd suggest either closing this as already-fixed-upstream, or keeping it
open as a reminder to bump maven-reporting-impl when it releases — happy to
send that upgrade PR (including migrating the deprecated `getOutputName()`
overrides to `getOutputPath()`, which maven-reporting-api 4.1.0 already
provides). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
