slachiewicz opened a new pull request, #3573: URL: https://github.com/apache/maven-surefire/pull/3573
Replaces the `StringUtils` and `io.FileUtils` uses of maven-shared-utils with the commons-lang3 and commons-io copies that `surefire-shared-utils` already shades (`StringUtils.capitalizeFirstLetter` → `capitalize`, `chompLast` → `removeEnd`, and the trimming `isEmpty` → `isBlank`, since commons-lang3's `isEmpty` does not trim). In `surefire-report-parser`, `DirectoryScanner` moves to plexus-utils (declared explicitly, version managed by the parent), the include/exclude lists become arrays so no `split` is needed, and the two blank checks become a small local helper; the module no longer depends on maven-shared-utils. `FileUtils.loadFile` becomes a few lines of `java.nio.file.Files`, keeping its trim, `#` comment and default-charset behaviour. Still on maven-shared-utils: `cli`, `ShutdownHookUtils` and `logging` (no replacement yet; `logging` waits for the Maven 3.10 floor), plus the shaded `xml` writers, `SelectorUtils`, `MatchPatterns` and `DirectoryScanner`, because plexus-utils is not on those modules' classpath. Verified: `mvn verify -pl surefire-report-parser,maven-surefire-report-plugin,maven-surefire-common,surefire-api,surefire-booter,surefire-extensions-api -am` → unit tests pass; `surefire-its` not run. Part of apache/maven-shared-utils#452. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
