olamy opened a new pull request, #3571: URL: https://github.com/apache/maven-surefire/pull/3571
Since 3.6.0 every JUnit 4 test runs on the JUnit Platform through the vintage engine, which needs JUnit 4.12 or newer. A few checks and docs still talked about the old JUnit 4.7 provider. - The groups/excludedGroups check no longer looks at the JUnit version. A JUnit older than 4.12 is already rejected by `createProviders()`, which names the version it found, so the groups check only fails when the module has no test framework at all. Before this, JUnit 4.7 to 4.11 passed the groups check and then failed in `createProviders()` anyway. - The 4.12 minimum now lives in one place, `SurefireDependencyResolver.MINIMUM_JUNIT4_VERSION_SPEC`. - Remove the unused `ProviderInfo.Engine` enum, the JUnit 4.7 helpers and a duplicated engine resolution block in `getProviderClasspath()`. - Parameter docs say "JUnit 4 via the Vintage engine" instead of "JUnit 4.7 provider". This sits on top of #3570: the groups check stays where #3570 moved it, after the test scan. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
