boolean values in the POM specified as expressions are not interpolated, result 
in value == false
-------------------------------------------------------------------------------------------------

                 Key: MNG-3443
                 URL: http://jira.codehaus.org/browse/MNG-3443
             Project: Maven 2
          Issue Type: Bug
          Components: POM
    Affects Versions: 2.0.8, 2.1-alpha-1
            Reporter: John Casey
         Attachments: interpolate-boolean-expression.zip

The problem is the ModelReader generated by Modello uses something akin to 
Boolean.valueOf( element.getValue() ) to set boolean model values. If the value 
in XML is actually an expression, it is resolved to false and never 
interpolated.

To correct this, we should consider revising Modelllo's generated reader 
architecture to use a two-stage approach:

1. Construct a raw structure of String: String and String: Collection 
associations (basically something like a perlish hash, IIRC)
2. Pass an arbitrary number of transformers over the raw structure to 
interpolate it (this includes path translation, etc. and should include a 
notion of transformation context to allow transformations to collaborate)
3. Construct the Model instance based on the transformed raw structure.

This will incur a little extra transient overhead for model construction, but 
its effects should be mitigated through the caching strategies we employ for 
models and projects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to