slachiewicz opened a new pull request, #871: URL: https://github.com/apache/maven-shade-plugin/pull/871
Fixes #595. `IncludeResourceTransformer.hasTransformedResource()` returned false for a missing file, so a typo in `<file>` dropped the resource from the shaded jar without a message. The build now fails with the configured path and resource in the error, as it already does for a missing `extraJars` path. The discussion on the issue preferred an unconditional error over an option. This bit Apache XTable: a bundled jar shipped without `META-INF/LICENSE` because its transformer pointed at a file that did not exist (apache/incubator-xtable#991). Verified: the new IT `include-resource-missing-file` fails on `master` (the build succeeds) and passes with this change. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
