slachiewicz opened a new pull request, #872: URL: https://github.com/apache/maven-shade-plugin/pull/872
`DefaultShader` offers each resource to the transformers in configuration order and stops at the first one whose `canTransformResource` accepts it ([DefaultShader.java:676-688](https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L676-L688)). The resource transformers page never says so. With `DontIncludeResourceTransformer` listed before `ApacheNoticeResourceTransformer`, every `NOTICE` is dropped before it can be merged; Apache XTable carries a comment in each of its shaded poms warning about exactly this (apache/incubator-xtable#991). This adds one paragraph at the top of the page and one sentence to the `DontIncludeResourceTransformer` section. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
