slachiewicz opened a new pull request, #877:
URL: https://github.com/apache/maven-shade-plugin/pull/877

   Fixes #876. Stacked on #871: without #871, claiming the existing entry while 
the configured file is missing would drop the resource from the jar silently. 
Review and merge #871 first; this PR then shows only its own commit.
   
   `IncludeResourceTransformer.canTransformResource` now claims entries with 
the transformer's resource name, matched case-insensitively as 
`AppendingTransformer` does, so the configured file replaces them instead of 
colliding with them. A transformer listed earlier that matches the same name, 
such as `DontIncludeResourceTransformer`, still takes the entry first.
   
   Verified: the new IT `include-resource-existing-entry` fails on `master` 
with `duplicate entry: META-INF/README.txt` and passes with this change, with 
the configured file's content in the jar.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to