arturobernalg commented on PR #13727: URL: https://github.com/apache/maven/pull/13727#issuecomment-6442661025
Pushed c2a9171, applying both suggestions: - @slawekjaranowski: switched to the exact class name `org.fusesource.jansi.Ansi` instead of the `org.fusesource.jansi.*` wildcard. Checked `Entry#matches()` in plexus-classworlds: a non-wildcard entry (no trailing `.*`) matches only that exact class name, the same way other entries in this file already do (e.g. `org.apache.maven.artifact`). Same behavior today since `Ansi` is the only class `maven-jline` ships, but it no longer silently claims the whole package if real jansi classes with the same simple names ever show up there. - @gnodet-bot: dropped the `SelfFirstStrategy` mention in the XML comment -- the import-with-fallback happens in `ParentFirstStrategy` too, so citing one strategy implied it was strategy-dependent. Added a second assertion so the test also locks in that the exact-class export stays. Full suite, checkstyle and spotless pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
