gnodet-bot commented on code in PR #480:
URL:
https://github.com/apache/maven-install-plugin/pull/480#discussion_r4386159401
##########
.github/dependabot.yml:
##########
@@ -33,6 +33,21 @@ updates:
# Maven 3 so use SLF4J 1.7.x
- dependency-name: "org.slf4j:*"
versions: [">= 2.0.0"]
+ # Maven 3 line stays on Resolver 1.x (2.x is Maven 4)
Review Comment:
⚠️ **Factually wrong comment.** `(2.x is Maven 4)` is incorrect — Resolver
2.x is not exclusive to Maven 4. Maven 3.10.0 ships with Resolver 2.0.24 (as
acknowledged in the comment below: *"3.10 would pull in Resolver 2.x"*). The
actual rationale here is that this project's baseline is Maven 3.9.x, not that
2.x belongs to Maven 4 only.
```suggestion
# Stay on Resolver 1.x (Maven 3.9 baseline; 3.10+ and Maven 4 use
Resolver 2.x)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
