gnodet-bot commented on code in PR #732:
URL:
https://github.com/apache/maven-deploy-plugin/pull/732#discussion_r4386147268
##########
.github/dependabot.yml:
##########
@@ -34,6 +34,21 @@ updates:
# Maven 3 so use SLF4J 1.7.x
- dependency-name: "org.slf4j:*"
versions: [">= 2.0.0"]
+ # Maven 3 line stays on Resolver 1.x (2.x is Maven 4)
Review Comment:
⚠️ **Still unaddressed from previous review:** `(2.x is Maven 4)` is
incorrect — Maven 3.10.x also uses Resolver 2.x (see [3.10.0 release
notes](https://maven.apache.org/docs/3.10.0/release-notes.html)). Notably, the
comment you added just below (lines 40–41) correctly states `"3.10 would pull
in Resolver 2.x"` — the two comments now contradict each other.
Update to accurately describe the constraint:
```suggestion
# Maven 3.9.x line stays on Resolver 1.x; 3.10.x+ also uses 2.x but
master targets 3.9.x.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
