gnodet-bot commented on PR #13695: URL: https://github.com/apache/maven/pull/13695#issuecomment-6383160373
🟠**Missing test coverage for bootstrap→real drain transition.** The core new functionality — `BootstrapLoggerManager` buffering events and draining them on `install()` — has zero test coverage. The four new classes (`BootstrapLogEvent`, `BootstrapLogEventBuilder`, `BootstrapLogger`, `BootstrapLoggerManager`) are untested. A test in `maven-api-log` should verify: 1. Events logged before `LoggerManager.set()` appear in the real sink after install 2. `pendingRootLevel` is forwarded on drain 3. A `BootstrapLogger` held in a field continues to route to the real logger after install (auto-upgrade via `delegate`) This is non-trivial concurrency-adjacent code. Without a test, a regression in the drain path would produce silent event loss — the exact failure mode the bootstrap tier is designed to prevent. _This review was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
