gnodet-bot commented on code in PR #2205:
URL: https://github.com/apache/maven-resolver/pull/2205#discussion_r4252119471
##########
maven-resolver-spi/pom.xml:
##########
@@ -43,6 +43,10 @@
<groupId>org.apache.maven.resolver</groupId>
<artifactId>maven-resolver-api</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
Review Comment:
`slf4j-api` is being added at compile scope to the **SPI** module
(`maven-resolver-spi`), making it a transitive runtime dependency for every
consumer. `PathProcessorSupport` is an implementation class, not part of the
API surface; all 17 downstream modules already declare `slf4j-api` themselves.
Two options worth considering:
1. Move `PathProcessorSupport` to `maven-resolver-impl` (where
implementation classes live) and keep the SPI dependency surface clean.
2. Accept the `slf4j-api` dependency on the SPI module if
`PathProcessorSupport` is genuinely intended as a base class for third-party
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
