efegokdemir commented on PR #179: URL: https://github.com/apache/maven-shared-jar/pull/179#issuecomment-6085202304
I looked into the constructor suggestion. `JarAnalyzer` creates `JarData` before class analysis runs; `JarClassesAnalysis` then populates class data on demand, while hash and identification analyzers populate other fields separately. Making `JarData` immutable would therefore change the analysis lifecycle and public API, rather than just this accessor fix. I have not broadened this PR into that redesign. If you have a specific lifecycle/API direction in mind, I can align the fix with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
