gnodet-bot commented on code in PR #1155: URL: https://github.com/apache/maven-compiler-plugin/pull/1155#discussion_r4181635433
########## src/it/abi-incremental-cascade/verify.groovy: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +// All class files should exist +assert new File( basedir, 'target/classes/api/Model.class' ).exists() +assert new File( basedir, 'target/classes/impl/Service.class' ).exists() + +// Graph state is stored in maven-status dir (not inside classes/ to avoid polluting JARs) +assert new File( basedir, 'target/maven-status/maven-compiler-plugin/classes/incremental-state' ).exists() Review Comment: 🔴 **Bug:** This assertion checks for `.abi-incremental-state`, but `GraphIncrementalBuild` writes its state as `.incremental-state` (line 105 of `GraphIncrementalBuild.java`). Both ITs set `incrementalStrategy=graph`, so the `GraphIncrementalBuild` engine runs, not a separate ABI engine. This assertion will fail when the IT runs. The basic IT's verify.groovy correctly checks `.incremental-state` — this one needs to match. ```suggestion assert new File( basedir, 'target/maven-status/maven-compiler-plugin/classes/.incremental-state' ).exists() ``` ########## src/it/abi-incremental-cascade/verify.groovy: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +// All class files should exist +assert new File( basedir, 'target/classes/api/Model.class' ).exists() +assert new File( basedir, 'target/classes/impl/Service.class' ).exists() + +// Graph state is stored in maven-status dir (not inside classes/ to avoid polluting JARs) Review Comment: 📝 Comment says "ABI state" but the strategy is `graph` (set in `pom.xml`). Suggest aligning the comment with the actual strategy name: ```suggestion // Graph state is stored in maven-status dir (not inside classes/ to avoid polluting JARs) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
