gnodet-bot commented on code in PR #13331:
URL: https://github.com/apache/maven/pull/13331#discussion_r4178617402
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultProfileActivationContext.java:
##########
@@ -226,6 +226,21 @@ DefaultProfileActivationContext start() {
new Record());
}
+ /**
+ * Like {@link #start()}, but resolves model properties from the given
properties.
+ */
+ DefaultProfileActivationContext start(Map<String, String> modelProperties)
{
+ return new DefaultProfileActivationContext(
+ rootLocator,
+ interpolator,
+ activeProfileIds,
+ inactiveProfileIds,
Review Comment:
💡 **Nit:** The Javadoc could be more precise about what this method does —
specifically that it creates a nested recording context whose model properties
are overridden, while preserving the original model's
basedir/packaging/artifactId for exists-check evaluation.
```suggestion
/**
* Like {@link #start()}, but overrides the model's properties with the
given map.
* The model's other attributes (basedir, packaging, artifactId) are
preserved
* so that file-exists profile conditions resolve against the original
project directory.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
