desruisseaux commented on code in PR #1136:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1136#discussion_r4174569259
##########
src/test/java/org/apache/maven/plugin/compiler/CompilerMojoTestCase.java:
##########
@@ -247,15 +250,9 @@ public void
testCompilerProcFullRunsWhenSourcesAreUnchanged(
@Basedir("${basedir}/target/test-classes/unit/compiler-proc-only-explicit-incremental-test")
public void testCompilerProcOnlyRespectsExplicitIncrementalCompilation(
@InjectMojo(goal = "compile", pom = "plugin-config.xml")
CompilerMojo compileMojo) {
- Log log = mock(Log.class);
- compileMojo.logger = log;
- compileMojo.execute();
-
- clearInvocations(log);
- compileMojo.execute();
-
- verify(log, never()).info("Nothing to compile - all classes are up to
date.");
- assertCompilerStubOutputFileExists(compileMojo);
Review Comment:
This change removes a lot of value to this test. The whole
`test-classes/unit/compiler-proc-only-explicit-incremental-test` directory
become ignored. What was non-deterministic in the previous version? If
nevertheless we keep this change, then we should at least remove what is no
longer necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
