efegokdemir opened a new pull request, #698:
URL: https://github.com/apache/maven-jlink-plugin/pull/698

   Fixes #697
   
   On Windows, maven-shared-utils' `CmdShell` already quotes the complete `/X 
/C` command. The toolchain executor was causing the command to be quoted a 
second time, producing a failing `cmd.exe /C ""..."` invocation.
   
   This keeps the existing Unix command construction unchanged and uses a small 
Windows shell adapter so the executable path and arguments are passed as one 
correctly quoted command. The Windows-focused test now guards against the 
duplicated quotes.
   
   Validation:
   - `mvn -Dspotless.skip=true -Dtest=JLinkMojoTest test` — passed (6 tests, 1 
skipped)
   - Checkstyle — 0 violations
   - `git diff --check`
   - Default Spotless run was blocked by an existing Palantir formatter 
`NoSuchFieldError` under Java 27; Spotless was skipped only for the focused 
test run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to