efegokdemir commented on code in PR #414:
URL: https://github.com/apache/maven-archiver/pull/414#discussion_r4155666494
##########
src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java:
##########
@@ -632,7 +632,7 @@ private static Properties loadOptionalProperties(final
InputStream inputStream)
try (InputStream in = inputStream) {
properties.load(in);
} catch (IllegalArgumentException | IOException ex) {
- // ignore and return empty properties
+ throw new IllegalStateException("Unable to read Maven Archiver
properties", ex);
Review Comment:
The current head now catches malformed or unreadable pom.properties, logs a
warning, and falls back to the description without a version; archive creation
continues. I also updated the PR description to match this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
