gnodet-bot commented on code in PR #536:
URL:
https://github.com/apache/maven-resources-plugin/pull/536#discussion_r4143292730
##########
src/main/java/org/apache/maven/plugins/resources/ResourcesMojo.java:
##########
@@ -433,6 +433,24 @@ public class ResourcesMojo implements
org.apache.maven.api.plugin.Mojo {
@Parameter(property = "maven.resources.failOnMissingFilterValue",
defaultValue = "false")
private boolean failOnMissingFilterValue;
+ /**
+ * When set to {@code true}, files that trigger a {@code
MalformedInputException} during filtering
+ * (i.e. binary files whose encoding cannot be read as text) are silently
skipped and copied as-is
+ * instead of failing the build. A {@code WARN}-level log entry is emitted
for each skipped file.
+ * <p>
+ * Use this as a last-resort fallback when it is not practical to
enumerate every binary extension
+ * in {@code nonFilteredFileExtensions} or to exempt files via
per-resource {@code nonFilteredFiles}
+ * glob patterns. Prefer those targeted approaches when possible.
+ * </p>
+ * <p>
+ * Defaults to {@code false} so that real encoding errors are not silently
swallowed.
+ * </p>
+ *
+ * @since 4.0.0-beta-3
Review Comment:
🔴 **Wrong `@since` tag.** Current version is `4.0.0-beta-2-SNAPSHOT` — this
parameter will ship in `beta-2`, not `beta-3`. The sister parameter
`failOnMissingFilterValue` just above correctly uses `@since 4.0.0-beta-2`.
```suggestion
* @since 4.0.0-beta-2
```
##########
src/main/java/org/apache/maven/plugins/resources/ResourcesMojo.java:
##########
@@ -433,6 +433,24 @@ public class ResourcesMojo implements
org.apache.maven.api.plugin.Mojo {
@Parameter(property = "maven.resources.failOnMissingFilterValue",
defaultValue = "false")
private boolean failOnMissingFilterValue;
+ /**
+ * When set to {@code true}, files that trigger a {@code
MalformedInputException} during filtering
+ * (i.e. binary files whose encoding cannot be read as text) are silently
skipped and copied as-is
Review Comment:
💡 **Minor wording nit:** "silently skipped" contradicts the next sentence
which says a `WARN` log is emitted. A warning is not silent. Consider dropping
"silently":
```suggestion
* When set to {@code true}, files that trigger a {@code
MalformedInputException} during filtering
* (i.e. binary files whose encoding cannot be read as text) are skipped
and copied as-is
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
