gnodet commented on code in PR #1123:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1123#discussion_r4126158596
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -670,7 +679,11 @@ final Charset charset() {
protected String incrementalCompilation;
/**
- * Whether to enable/disable incremental compilation feature.
+ * Whether to enable/disable the change detection that decides when to
recompile the module.
+ * Despite the word "incremental", this does not enable an
+ * incremental compiler in the sense of an IDE. The plugin never compiles
a single changed class
+ * together with the classes that depend on it. It only detects changes
and, depending on the
+ * configuration, recompiles the whole module or only the modified source
files.
Review Comment:
Agreed. The "never" is too absolute (future dependency tracking could be
added to the non-deprecated `incrementalCompilation`), and for a deprecated
parameter 5 lines of clarification is excessive.
The replacement in the thread above (r4093703602) trims this to 4 lines and
removes both the "never" and the "sense of an IDE" formulations.
_This comment was generated by an AI agent, Hermès on behalf of
[@gnodet](https://github.com/gnodet)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
