gnodet-bot commented on code in PR #1143:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1143#discussion_r4126095741
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -642,12 +642,17 @@ final Charset charset() {
*
* <h4>Default value</h4>
* The default value depends on the context.
- * If there is no annotation processor, then the default is {@code
"options,dependencies,sources"}.
- * It means that a full rebuild will be done if the compiler options or
the dependencies changed,
- * or if a source file has been deleted. Otherwise, only the modified
source files will be recompiled.
+ * If there is no annotation processor, then the default is {@code
"options,dependencies,sources,rebuild-on-change"}.
+ * It means that a full rebuild will be done if the compiler options, the
dependencies changed,
+ * if a source file has been deleted, or if any source file has been
modified.
+ * This ensures correctness: if a method signature changes in {@code
Foo.java}, all classes that depend
Review Comment:
💡 **Nit:** The sentence structure is a bit off — the first comma reads like
the start of a list but the conjunction ("or") is missing.
```suggestion
* It means that a full rebuild will be done if the compiler options or
the dependencies changed,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
