gnodet-bot commented on code in PR #424:
URL:
https://github.com/apache/maven-resources-plugin/pull/424#discussion_r4102759852
##########
pom.xml:
##########
@@ -178,9 +175,14 @@ under the License.
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.google.inject</groupId>
- <artifactId>guice</artifactId>
- <version>${guiceVersion}</version>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-testing</artifactId>
+ <version>${mavenVersion}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
Review Comment:
⚠️ **Still redundant — raised in both previous reviews.** `maven-testing`
declares `junit-jupiter-api` as a compile-scope dependency (confirmed from its
POM), so it's transitive here. This explicit entry is dead weight and creates a
version-drift risk.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
