gnodet commented on issue #521: URL: https://github.com/apache/maven-resources-plugin/issues/521#issuecomment-5823062564
Thanks for the suggestion! The `<source>` approach is elegant for Maven 4 and worth pursuing as a follow-up, but it operates at a different layer than what PR apache/maven-filtering#395 addresses. PR#395 adds the underlying primitives in `maven-filtering` itself — `nonFilteredFiles` glob patterns on `Resource` and the `gracefulBinaryHandling` flag on `MavenResourcesExecution`. Whatever syntax the plugin exposes (whether `<nonFilteredFiles>` blocks for Maven 3 compatibility, or `<source stringFiltering=false>` for Maven 4), it needs to map down to something in the filtering library. `nonFilteredFiles` is precisely that mapping point. The `<source>`-based approach also doesn't cover `gracefulBinaryHandling` (the opt-in fallback for `MalformedInputException`), which is a separate concern. So I'd see the two as complementary: PR#395 provides the library primitive; a follow-up maven-resources-plugin PR could expose both `<nonFilteredFiles>` (Maven 3 compat) and the `<source stringFiltering=false>` pattern (Maven 4 idiomatic). Would that work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
