[ 
http://jira.codehaus.org/browse/MCHECKSTYLE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Lundberg closed MCHECKSTYLE-86.
--------------------------------------

         Assignee: Dennis Lundberg
       Resolution: Fixed
    Fix Version/s: 2.2

Patch applied in r628373. Thanks!

> Lock down encoding used to read source files
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-86
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-86
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1
>            Reporter: Benjamin Bentmann
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: fixed-charset.patch
>
>
> Since [version 
> 3.5|http://checkstyle.sourceforge.net/releasenotes.html#Release%203.5], 
> Checkstyle allows to configure the encoding used to read source files 
> (somehow weird, they included this setting in the XML config which limits 
> reusability among unrelated projects). Unless this is specified by the user 
> via the [charset 
> property|http://checkstyle.sourceforge.net/config.html#TreeWalker], it 
> defaults to the system property "file.encoding". This makes the checks 
> platform-dependent and possibly fail. For reproducible builds, the encoding 
> should be locked down.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to