gnodet commented on PR #456: URL: https://github.com/apache/maven-install-plugin/pull/456#issuecomment-5804320173
Closing after thorough investigation of why the IT passes on rc-6. **Root cause of the false green:** In rc-6, not only stores the path in the map but **also** back-propagates it to the legacy layer: . This is still the case in master (same block). So even without our priority fix: 1. calls → legacy state is JAR 2. calls → overwrites legacy state back to POM via 3. hits the project loop → returns from the now-corrected The fix is correct (checking the map first is the right invariant), but **the bug cannot be reproduced as a failing IT** with this scenario, because fixes the legacy state before is called. A failing IT would require a scenario where is called between a invocation (which sets the JAR file) and a call that hasn't happened yet — which doesn't happen in the normal flow. The maven core fix (apache/maven#13256) still stands as a correctness improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
