gnodet opened a new pull request, #455:
URL: https://github.com/apache/maven-install-plugin/pull/455

   ## Summary
   
   Fixes https://github.com/apache/maven-install-plugin/issues/251
   
   The `install-file` goal was declared as `aggregator = true`. This causes 
Maven's concurrent builder to acquire an **exclusive write lock** on the 
reactor whenever `install-file` runs, which:
   
   1. Serializes all concurrent `install-file` executions in parallel builds 
(`-T N`)
   2. Emits a spurious warning: _"The …:install-file aggregator mojo is already 
being executed in this parallel build, those kind of mojos require exclusive 
access to reactor…"_
   
   This contradicts the documented behaviour that the goal _"is thread-safe and 
supports parallel builds"_.
   
   ## Root cause
   
   `aggregator = true` was historically added to allow `install-file` to be 
invoked from the root of a multi-module build without a project. However, that 
is already handled by `projectRequired = false`. The `aggregator` flag is the 
wrong tool here and has no benefit: `install-file` does not read or modify any 
reactor `MavenProject`, so it needs no exclusive reactor access.
   
   ## Fix
   
   Remove `aggregator = true` from the `@Mojo` annotation on `InstallFileMojo`. 
The `projectRequired = false` attribute is retained and is sufficient.
   
   ## IT
   
   `src/it/MINSTALL-205` — a two-module project that invokes 
`install:install-file` in both modules under `-T2`. The `verify.groovy` asserts:
   - Both artifacts were successfully installed to the local repository
   - The build log does **not** contain the aggregator warning
   
   Full `mvn verify -B -Prun-its` passes: **34/34 ITs, 0 failures**.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to