wilx opened a new pull request, #187: URL: https://github.com/apache/maven-invoker/pull/187
Add 14 Windows execution cases covering seven executable directory names, each resolved relatively and absolutely: plain paths, spaces, parentheses, ampersands, carets, and combinations. The CMD fixture verifies the invoked executable and arguments containing `& | < > ( ) ^`. Regression coverage for #127 (MSHARED-832). Companion quoting fix: https://github.com/apache/maven-shared-utils/pull/441. The shared-utils change also addresses quoting of spaced PowerShell host paths; this PR exercises Invoker's CMD execution path. **Draft:** the POM still uses maven-shared-utils 3.4.2. These tests expect the companion branch's quoting behavior, so a compatible dependency update and Windows validation are needed before merging. Issue #127 was recently closed because Invoker is deprecated; this PR makes the existing regression coverage available for review. Validation: Java 8 on Linux, `mvn -o -B -V clean verify`: 109 tests, 0 failures/errors, 2 Windows-only skips. The new Windows test factory was skipped, so its 14 execution scenarios were not run locally. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Your pull request should address just one issue, without pulling in other changes. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. - [x] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
