efegokdemir opened a new pull request, #53: URL: https://github.com/apache/maven-executor/pull/53
## Summary Fixes #46 by snapshotting system properties when each embedded Maven execution begins. Reusable executors now preserve caller changes made between executions instead of restoring a constructor-time snapshot. ## Changes - Capture the system-properties snapshot at the start of `EmbeddedMavenExecutor.execute()`. - Add a regression test that replaces the system-properties object between two executions. ## Testing - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -pl maven-executor -Dtest=EmbeddedMavenExecutorTest#preservesSystemPropertiesSetBetweenExecutions test` — PASS. - The regression test failed before the production change with the expected missing property, then passed after the change. - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -pl maven-executor -DskipTests verify` — PASS. - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -pl maven-executor test` — 60 passed, 1 existing baseline failure in `defaultFs4CaptureOutputWithForcedColor`; the same failure reproduces on the unmodified `main` branch. - `git diff --check` — PASS. ## Notes No competing open PR was found for #46 during the final duplicate check. AI assistance was used; the submitter has reviewed the complete diff and is responsible for the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
