gnodet-bot commented on code in PR #13239: URL: https://github.com/apache/maven/pull/13239#discussion_r4072186742
########## apache-maven/src/assembly/maven/bin/mvn: ########## @@ -462,6 +462,41 @@ if $cygwin || $mingw ; then fi MAVEN_PROJECTBASEDIR="$MAVEN_PROJECTBASEDIR_NATIVE" +# MNG-8056: Under Cygwin, the JVM is a native Windows process and cannot resolve +# Cygwin-style POSIX paths (e.g. /cygdrive/c/...) directly. The internal paths +# (MAVEN_HOME, CLASSWORLDS_CONF, JAVA_HOME, …) are already converted above, but +# user-supplied paths passed via -f/--file, -s/--settings, -gs/--global-settings, +# -st/--toolchains and -gt/--global-toolchains reach the JVM unconverted. Review Comment: 🔧 **Nit: comment is stale — it lists only the original two flags, not the full set now handled.** The comment says _"-st/--toolchains and -gt/--global-toolchains reach the JVM unconverted"_ but the code below now handles `-t`, `-ps`/`--project-settings`, `-is`/`--install-settings`, `-it`/`--install-toolchains`, `-l`/`--log-file`, and `-af`/`--at-file` as well. A future maintainer reading this comment would believe only two flags were ever addressed. Update it to reflect the full set: ```suggestion # -f/--file, -s/--settings, -gs/--global-settings, -t/--toolchains, -gt/--global-toolchains, # -ps/--project-settings, -is/--install-settings, -it/--install-toolchains, # -l/--log-file, and -af/--at-file reach the JVM unconverted. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
