[
http://jira.codehaus.org/browse/SUREFIRE-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123962
]
Dan Fabulich commented on SUREFIRE-452:
---------------------------------------
Two points.
1) I find it hard to believe that you're "blocked" by this bug. Yes, it's
certainly annoying that everything gets dumped into a file called
TestSuite.xml. But that's only bothering you because of a bug in JUnitReport
where it only pays attention to the name of the file, instead of paying
attention to the "classname" attribute inside the XML file.
http://issues.apache.org/bugzilla/show_bug.cgi?id=24106
JUnitReport is kinda broken. May I recommend our fine Surefire Report instead?
2) I just attempted to test your revised patch, and I didn't entirely grasp the
intended effect of this code. This code doesn't do anything *except* honor the
"suitename" option if you forcibly pass it in. Naturally, you can only do this
on a per-project basis.
I don't think this really helps you very much. All test results are going to
go into one file, and because of Ant bug 24106, all test results will be
reported as coming from one class. Does it matter whether the file is called
"TestSuite" or whether it's called ${artifactId}? You still won't be able to
tell what class had a test failure.
> suitename always = "TestSuite" even if <suitename> defined as property
> ----------------------------------------------------------------------
>
> Key: SUREFIRE-452
> URL: http://jira.codehaus.org/browse/SUREFIRE-452
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.4, 2.4.1
> Environment: Maven version: 2.0.8
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> and also on Linux
> Reporter: Erez Nahir
> Fix For: 2.x
>
> Attachments: TestNGDirectoryTestSuite.java,
> TestNGDirectoryTestSuite.java
>
>
> Using surefire and testng with no testng.xml but with <cofiguration>, the
> generated standard output xml always have suite name="TestSuite".
> This is an issue while using CruiseControl and JUnitReport to generate a
> JUnit report.
> Here is the configuration in my pom file:
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-surefire-plugin</artifactId>
> <version>2.4.1</version>
> <configuration>
> <testFailureIgnore>true</testFailureIgnore>
> <groups>fast</groups>
> <excludedgroups>broken</excludedgroups>
> <properties>
> <property>
> <name>suitename</name>
> <value>${artifactId}</value>
> </property>
> <property>
> <name>testname</name>
> <value>${artifactId}</value>
> </property>
> </properties>
> </configuration>
> </plugin>
> There is an attached patch too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
