gnodet-bot commented on code in PR #2149: URL: https://github.com/apache/maven-resolver/pull/2149#discussion_r4069046610
########## maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpTransporterTest.java: ########## @@ -18,20 +18,44 @@ */ package org.eclipse.aether.transport.http; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; Review Comment: 🔧 **Import order**: `javax.*` before `java.*` violates the convention in every other file in this project (including the pre-existing baseline of this file). Standard Apache/Maven order is `java.*` → `javax.*` → `org.*`. Checkstyle will likely flag this. ```suggestion import java.io.File; import java.io.FileNotFoundException; ``` Move the two `javax.servlet.http` imports after all `java.*` imports (just before the `org.apache.http.*` block). ########## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/SystemProxyAuthenticationStrategy.java: ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.eclipse.aether.transport.http; + +import java.util.Locale; +import java.util.Map; +import java.util.Queue; + +import org.apache.http.Header; +import org.apache.http.HttpHost; +import org.apache.http.HttpRequest; +import org.apache.http.HttpRequestInterceptor; +import org.apache.http.HttpResponse; +import org.apache.http.auth.AuthOption; +import org.apache.http.auth.AuthScope; +import org.apache.http.auth.AuthState; +import org.apache.http.auth.MalformedChallengeException; +import org.apache.http.auth.NTCredentials; +import org.apache.http.auth.UsernamePasswordCredentials; +import org.apache.http.client.CredentialsProvider; +import org.apache.http.client.config.AuthSchemes; +import org.apache.http.client.protocol.HttpClientContext; +import org.apache.http.conn.routing.RouteInfo; +import org.apache.http.impl.client.BasicCredentialsProvider; +import org.apache.http.impl.client.ProxyAuthenticationStrategy; +import org.apache.http.protocol.BasicHttpContext; +import org.apache.http.protocol.HttpContext; + +/** + * Adds system proxy credentials only while selecting authentication for the current route's proxy. + */ Review Comment: 🔧 **Missing `@since` tag**: the master-branch equivalent (`maven-resolver-transport-apache`) carries `@since 2.0.24`. This backport should document when the feature was introduced on the 1.9.x line. ```suggestion /** * Adds system proxy credentials only while selecting authentication for the current route's proxy. * * @since 1.9.23 */ ``` (Adjust the version to whatever `1.9.x` release this targets.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
