slachiewicz opened a new pull request, #1390:
URL: https://github.com/apache/maven-javadoc-plugin/pull/1390

   maven-invoker is deprecated in favour of 
[maven-executor](https://github.com/apache/maven-executor) 
(apache/maven-invoker#164). `JavadocUtil.invokeMaven`, which runs 
`javadoc:javadoc` in a sibling module whose apidocs are missing when offline 
links are detected, now builds the command line itself (`-B`, `-X` in debug, 
`-f`, `-gs`/`-s`/`-gt`/`-t` for the settings and toolchains files, 
`-Dmaven.repo.local`, the properties) and runs it with `ForkedMavenExecutor` on 
the same `maven.home`; `JAVA_HOME` goes through the request's environment, and 
the retry with an empty `MAVEN_OPTS` after a VM initialization error is 
unchanged. The invoker log keeps its header and content. `invokeMaven` throws 
`MojoExecutionException` where it threw the invoker's 
`MavenInvocationException`; `AbstractJavadocMojo` is the only caller.
   
   Verified: `mvn -Prun-its verify` → 81 ITs passed, 11 skipped by JDK 
condition. None of them reaches `invokeMaven`, so it was exercised separately 
with a two-module project where module `a` skips javadoc and `b` depends on it: 
`mvn javadoc:javadoc -pl b -am` logs "Trying to invoke it", and 
`b/target/invoker/maven-javadoc-plugin*.txt` holds the header and the nested 
build's `BUILD SUCCESS`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to