slachiewicz opened a new pull request, #216: URL: https://github.com/apache/maven-verifier/pull/216
Closes #215. `Embedded3xLauncher.createFromMavenHome` now checks the launcher's main class for Maven 4's `main(String[], ClassWorld, InputStream, OutputStream, OutputStream)` and calls it with the build log as both streams; a Maven 3 `MavenCli` still goes through `doMain`. Maven 4 reads the working directory from `user.dir`, which `run` sets already. The Maven version comes from the main class's loader instead of the `MavenCli` instance, which Maven 4 does not have. The test project's POM pointed its parent at `../maven-shared-components`, which Maven 4 refuses when nothing is there; it uses an empty `relativePath` now. `createFromClasspath` stays Maven 3 only. Verified: `mvn verify` on 4.0.0-rc-6 and on 3.10.0-rc-1 → 19 tests, 0 failures each (`Embedded3xLauncherTest.testWithMavenHome` and `VerifierTest.useRealLogFile` failed on rc-6 before). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
