gnodet-bot commented on code in PR #298:
URL: https://github.com/apache/maven/pull/298#discussion_r4047802065
##########
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java:
##########
@@ -342,37 +342,40 @@ private List<MavenProject>
getProjectsForMavenReactor(MavenSession session) thro
}
List<File> files = Arrays.asList(request.getPom().getAbsoluteFile());
- collectProjects(projects, files, request);
+ session.setModelProblems(collectProjects(projects, files, request));
Review Comment:
You're right — withdrawing that finding. In a pomless execution, the build
uses Maven's internal standalone POM
(`DefaultMaven.class.getResource("project/standalone.xml")`), which is a fixed
resource. Since Enforcer rules must be configured in the project POM, there is
no way to configure an Enforcer rule in a pomless build. The pomless path can
never trigger the proposed Enforcer rule, making an explicit
`setModelProblems()` call there purely academic. The remaining open issue (from
my last review) is the test coverage gap for that branch, but given the use
case doesn't exist, even that is low priority.
_This comment was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
