gnodet-bot commented on code in PR #13169: URL: https://github.com/apache/maven/pull/13169#discussion_r4045101946
########## its/core-it-suite/src/test/java/org/apache/maven/it/MavenITgh12625BomConsumerPomPropertyResolutionTest.java: ########## @@ -46,7 +46,7 @@ * @see <a href="https://lists.apache.org/thread/2s2myrg0zzk0q5z9kjhm8pwsntxmtnxh";>Vote thread</a> * @since 4.0.0 */ -class MavenITBomConsumerPomPropertyResolutionTest extends AbstractMavenIntegrationTestCase { +class MavenITgh12625BomConsumerPomPropertyResolutionTest extends AbstractMavenIntegrationTestCase { MavenITBomConsumerPomPropertyResolutionTest() { super("[4.0.0-rc-4,)"); Review Comment: **Compile error:** Constructor name does not match the class name after rename. ```java // current (broken) MavenITBomConsumerPomPropertyResolutionTest() { // fix MavenITgh12625BomConsumerPomPropertyResolutionTest() { ``` ########## its/core-it-suite/src/test/java/org/apache/maven/it/MavenITgh11767ConsumerPomBomFromSettingsRepoTest.java: ########## @@ -43,7 +43,7 @@ * * @since 4.0.0 */ -class MavenITConsumerPomBomFromSettingsRepoTest extends AbstractMavenIntegrationTestCase { +class MavenITgh11767ConsumerPomBomFromSettingsRepoTest extends AbstractMavenIntegrationTestCase { MavenITConsumerPomBomFromSettingsRepoTest() { super("[4.0.0-rc-1,)"); Review Comment: **Compile error:** Constructor name does not match the class name after rename. ```java // current (broken) MavenITConsumerPomBomFromSettingsRepoTest() { // fix MavenITgh11767ConsumerPomBomFromSettingsRepoTest() { ``` Java requires the constructor name to be identical to the class name. This will not compile. ########## its/core-it-suite/src/test/java/org/apache/maven/it/MavenITgh12922MvnupToolchainPluginStrategyTest.java: ########## @@ -41,7 +41,7 @@ * * @since 4.0.0-rc-7 */ -public class MavenITMvnupToolchainPluginStrategyTest extends AbstractMavenIntegrationTestCase { +public class MavenITgh12922MvnupToolchainPluginStrategyTest extends AbstractMavenIntegrationTestCase { public MavenITMvnupToolchainPluginStrategyTest() { super(ALL_MAVEN_VERSIONS); Review Comment: **Compile error:** Constructor name does not match the class name after rename. ```java // current (broken) public MavenITMvnupToolchainPluginStrategyTest() { // fix public MavenITgh12922MvnupToolchainPluginStrategyTest() { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
