gnodet-bot commented on code in PR #13156:
URL: https://github.com/apache/maven/pull/13156#discussion_r4033704718
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelBuilderTest.java:
##########
@@ -197,7 +199,7 @@ public void testActiveByDefaultProfileRepositoryHonored() {
.session(session)
.requestType(ModelBuilderRequest.RequestType.CONSUMER_DEPENDENCY)
.source(Sources.resolvedSource(
- getPom("active-by-default-profile"),
"org.apache.maven.test:active-by-default-profile:1.0.0"))
+ getPom("active-by-default-profile"),
"org.apache.maven.tests:active-by-default-profile:1.0.0"))
Review Comment:
**Wrong direction.** Every other `resolvedSource` call in this class uses
`org.apache.maven.test` (no `s`) as the modelId — lines 179, 241, 329, 413,
etc. This change adds an `s`, introducing a new inconsistency that directly
contradicts the PR's stated goal ("matching the fixture and existing test
convention").
The POM fixture is correctly being fixed *to* `org.apache.maven.test`. This
line should be left unchanged (it's already the right value):
```suggestion
getPom("active-by-default-profile"),
"org.apache.maven.test:active-by-default-profile:1.0.0"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
