desruisseaux commented on code in PR #1127:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1127#discussion_r4023075136
##########
src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java:
##########
@@ -475,22 +479,6 @@ private void setDependencyPaths(final
StandardJavaFileManager fileManager) throw
Optional<JavaFileManager.Location> location = type.location();
if (location.isPresent()) { // Cannot use
`Optional.ifPresent(…)` because of checked IOException.
var value = location.get();
- if (value == StandardLocation.CLASS_PATH) {
- if (isPartialBuild && !hasModuleDeclaration) {
Review Comment:
I don't think that you should delete this block, unless you find it to be
wrong. In my understanding, the only change which is needed is the removal of
the `isPartialBuild` flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
