slachiewicz opened a new pull request, #432: URL: https://github.com/apache/maven-shared-utils/pull/432
`executeCommandLineAsCallable` has taken a `Charset` since 3.3.x but never passed it to the two `StreamPumper` instances, so process output was always decoded with the JVM default charset. The synchronous `executeCommandLine` overload with a charset delegates here, so the parameter was dead in both. This wires it through; `StreamPumper` already had the constructor. The test runs `printf` through the shell to emit the UTF-8 bytes of "café" and decodes them once as UTF-8 and once as ISO-8859-1, so it holds whatever the platform default is. It is Unix-only like the neighbouring large-stdout test. Fixes #302. PR #60 was closed by the JIRA import, not by a fix. Verified: `mvn -B verify` on JDK 17 -> Tests run: 792, Failures: 0, Errors: 0; the new test fails on master with `expected: <café> but was: <café>`. *This change was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
