gnodet commented on code in PR #13040:
URL: https://github.com/apache/maven/pull/13040#discussion_r3935376139
##########
impl/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java:
##########
@@ -180,6 +199,19 @@ public ProjectSorter(Collection<MavenProject> projects)
throws CycleDetectedExce
.collect(Collectors.collectingAndThen(Collectors.toList(),
Collections::unmodifiableList));
}
+ private String resolveImportVersion(MavenProject project, String version) {
Review Comment:
💡 **Nit:** This method doesn't access any instance state — only its
parameters. It could be `static`.
```suggestion
private static String resolveImportVersion(MavenProject project, String
version) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
