slachiewicz opened a new pull request, #976: URL: https://github.com/apache/maven-wagon/pull/976
Drops the three deprecated or superseded `plexus-utils` APIs left in provider code, per #975: - `wagon-ssh-common` `StreamKnownHostsProvider` — `StringOutputStream` and `IOUtil.copy`/`IOUtil.close` become a `ByteArrayOutputStream` and try-with-resources. `toString()` without an explicit charset keeps the platform default `StringOutputStream` used. - `wagon-ssh` `AbstractJschWagon` — `IOUtil.close` becomes a local `closeQuietly`, keeping the null check and swallowed `IOException`. - `wagon-http-lightweight` `LightweightHttpWagon` — `plexus-utils` `Base64` becomes `java.util.Base64`. Base64 output is ASCII, so `encodeToString` matches the previous `new String(encodeBase64(...))`. Deliberately unchanged: the Basic credentials still go through `String.getBytes()` with the platform default charset. That is WAGON-627 / #787 territory and needs its own decision. Verified: `mvn install` on the three modules and their prerequisites → BUILD SUCCESS, `wagon-http-lightweight` 219/0/0 (7 skipped), `wagon-ssh-common` 10/0/0, `wagon-ssh-common-test` 19/0/0. Both changed paths are covered — `FileKnownHostsProvider` extends `StreamKnownHostsProvider`, and `LightweightHttpWagonWithPreemptiveAuthenticationTest` exercises the Basic header. Negative control: corrupting the encoded credentials turned that suite red (4 failures), so the passing run gates the change rather than skipping it. `spotless:check` passes. *This change was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
