slachiewicz opened a new pull request, #964: URL: https://github.com/apache/maven-wagon/pull/964
Backport improvements and cleanups from `master` to `wagon-3.x`: ### Bugfixes & Guards - **`AbstractWagon`**: Guard `createParentDirectories(File destination)` with `if (destinationDirectory == null) return;` preventing NPE when creating directories in the root directory. Remove redundant `input.close()` in `getTransfer`. - **`ScpHelper`**: Use try-with-resources for `ZipOutputStream` in `createZip`. Remove obsolete dead command comment. - **`RepositoryTest`**: Fix invalid IPv6 test URL syntax (`[fff:::1]` -> `[fff::1]`). - **`PathUtils`**: Add `@Deprecated` annotations on legacy static path and URL helpers. ### Documentation & Modernization - **`download.xml.vm`**: Modernize download page to `dlcdn.apache.org` and `downloads.apache.org` (replacing 2018 mirror dropdown script). - **`wagon-ssh`**: Migrate `configuration.xml` to Markdown (`configuration.md`), dropping obsolete duplicate sections. - **Site ATX headings**: Standardize markdown headers across provider docs (`wagon-ftp`, `wagon-http`, `wagon-webdav-jackrabbit`, `wagon-scm`, `wagon-http-lightweight`). ### Safe Code & Test Cleanups - **SSH tests**: Replace Plexus `FileUtils.fileRead` / `fileWrite` with standard Java NIO `Files.readAllBytes` and `Files.write` in `TestData`, `ShellCommand`, and `FileKnownHostsProviderTest`. - **`HttpWagonTests`**: Remove dead static `TMP_FILES` tracking and unused getters. - **`AbstractHttpClientWagonTest`**: Remove disabled external network-dependent dummy test. - **POM dependencies**: Add explicit `wagon-provider-api` dependency in `wagon-tcks/pom.xml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
