gnodet commented on PR #13032: URL: https://github.com/apache/maven/pull/13032#issuecomment-5530723471
Closing this — the record-accessor naming (`name()`, `value()`, `children()`) is intentional and consistent with the Maven 4 API design for immutable value types. See the detailed rationale on the issue: https://github.com/apache/maven/issues/11582#issuecomment-5530720249 In short: the noun-accessor pattern for immutable types is well established in the JDK itself (since Java 8/9, well before records), and `XmlNode` is an immutable value type by contract. Flipping the deprecation would break users who already migrated following the existing deprecation guidance, and create inconsistency with `PathType`, `Lifecycle.Phase`, `OsService`, `CIInfo` which all use the same pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
